DBParameterGroup reconciliation issues

[chlunde]

What happened?

Not all fields of DBParameterGroup are reconciled properly:

• Aftering removing a parameter in a DBParameterGroup, the value is not reset in AWS. There's a separate API call for this, ResetDBParameterGroup
• Tags are not reconciled
• List based parameters are normilized by AWS, so if the user writes 'foo, bar' AWS will report it back as 'foo,bar' and we will constantly reconcile.

How can we reproduce it?

• Test removing a parameter and ensure it is reset to false
• Add a tag, remove a tag
• Add rds.extensions pg_stat_statements, pgaudit and check cloud trail/the provider debug log/events, check if it constantly reconciles

What environment did it happen in?

Provider 0.19

[andyspiers]

Hi,

I have noticed that changes in tags are not reconciled on RDSInstance objects either.

What happens?

• If I just change a tag value, nothing is reconciled to AWS
• If I change a tag value and then also change a fairly insignificant parameter (doesn't cause DB to be restarted or recreated) like copyTagsToSnapshot then the new tag value is propagated to AWS.

(I'm also using 0.19)

I imagine #220 had some reasons for ignoring tag changes but I think it would be expected behaviour to be able to change them via Crossplane without having to apply a workaround like above.

Thanks! 🙂

[haarchri]

@chlunde is this still relevant ?