elasticache.cacheparametergroup: Add resource #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chlunde any progress here ? We also need this feature ;) |
chlunde
force-pushed
the
elasticache.cacheparametergroup
branch
3 times, most recently
from
b48c923
to
ccce455
Compare
Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
chlunde
force-pushed
the
elasticache.cacheparametergroup
branch
from
ccce455
to
8d62069
Compare
|
@haarchri I think it has the same quality as dbparametergroup, I don't remember why it was a draft. I think it works, I'm using it :-) Rebased, removed debug log statement and reran codegen. |
haarchri
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add elasticache.cacheparametergroup using code gen
Code gen is not perfect for parameter groups at the moment, so I skipped tags:
DBParameterGroupandDBClusterParameterGroupaws-controllers-k8s/community#869I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested