Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Amazon EC2 Instances #85

Closed
displague opened this issue Dec 2, 2019 · 8 comments · Fixed by #777
Closed

Add support for Amazon EC2 Instances #85

displague opened this issue Dec 2, 2019 · 8 comments · Fixed by #777
Assignees
Labels
enhancement New feature or request

Comments

@displague
Copy link
Contributor

What problem are you facing?

Since MachineInstance was implemented in crossplane/crossplane#942 in support of crossplane/crossplane#286, https://github.com/packethost/stack-packet remains the only provider to implement this claim kind.

How could Crossplane help solve your problem?

EC2 VM Instances should be supported for abstracting MachineInstance resources between providers.

@displague displague added the enhancement New feature or request label Dec 2, 2019
@hasheddan hasheddan changed the title Add support for Amazon EC2 Instances to provide MachineInstance support Add support for Amazon EC2 Instances Jun 5, 2020
@milindchawre
Copy link

milindchawre commented Jun 5, 2020

+1
Eagerly waiting for this feature. Just imagining what all cool things can be built once its implemented.

@afritzler
Copy link

@milindchawre same here! Machine instances + keypairs + EBS volumes + volume mounts would be pretty dope! 😎

@muvaf
Copy link
Member

muvaf commented Jan 20, 2021

I just tested whether this could be achieved by ACK code generation. But it seems like AWS API named instance creation command as RunInstances instead of CreateInstances, which causes ACK not to recognize it as a resource. However, a lot of EC2 resource are recognized, like key pairs volumes etc. So, if anyone is interested, you all are welcome to contribute with this new and much easier process to add a new resource 🙂

@surenraju-zz
Copy link

It will be really awesome if we are able to create EC2 instance! Eagerly waiting for this feature!!

@JAditya1395
Copy link

Hi All, So its been quite a while since the last comment on this thread. I am still very curious and excited for this feature but unfortunately i can not find anything conclusive. Is there a dedicated timeline for its support because it will be super helpfuil

@jbw976 jbw976 added this to Proposed in v1.4 via automation Jul 23, 2021
@jbw976 jbw976 moved this from Proposed to In progress in v1.4 Jul 23, 2021
@jbw976
Copy link
Member

jbw976 commented Jul 23, 2021

Thanks for weighing in on this issue @JAditya1395 and @surenraju!

@tnthornton has started working on this issue and has a draft PR open in #777 🎉

@tnthornton tnthornton self-assigned this Jul 23, 2021
@JAditya1395
Copy link

@jbw976 Thanks for the acknowledgement.
@tnthornton Great work Taylor. I am looking forward to this feature. I can see this i still a WIP but do we have any rough timeline where we can see this feature in the near future.

@tnthornton
Copy link
Contributor

tnthornton commented Jul 28, 2021

I can see this i still a WIP but do we have any rough timeline where we can see this feature in the near future.

FWIW, I just moved the PR out of draft state. I'll keep a close eye on PR comments so we can keep this moving along.

@negz negz moved this from In progress to Review in progress in v1.4 Aug 12, 2021
@negz negz removed this from Review in progress in v1.4 Aug 26, 2021
tektondeploy pushed a commit to gtn3010/provider-aws that referenced this issue Mar 12, 2024
align quickstart and provider versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants