Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generated-services) added docdb to makefile #1004

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented Dec 14, 2021

Signed-off-by: haarchri chhaar30@googlemail.com

Description of your changes

added docdb to makefile for generated-services
rerun make generate
test is failing

--- FAIL: TestCreate (0.00s)
    --- FAIL: TestCreate/SuccessfulCreate (0.00s)
        /Users/haarchri/Documents/test/provider-aws/pkg/controller/docdb/dbcluster/setup_test.go:2203: r: -want, +got:
              &v1alpha1.DBCluster{
              	TypeMeta:   {},
              	ObjectMeta: {Annotations: {"crossplane.io/external-name": "some-db-cluster"}},
              	Spec: v1alpha1.DBClusterSpec{
              		ResourceSpec: {},
              		ForProvider: v1alpha1.DBClusterParameters{
              			Region:                      "",
            - 			AvailabilityZones:           []*string{&"test-zone-a", &"test-zone-b"},
            + 			AvailabilityZones:           nil,
            - 			BackupRetentionPeriod:       &10,
            + 			BackupRetentionPeriod:       nil,
              			DBClusterParameterGroupName: &"some-db-cluster-parameter-group",
              			DBSubnetGroupName:           &"some-db-subnet-group",
            - 			DeletionProtection:          &true,
            + 			DeletionProtection:          nil,
              			EnableCloudwatchLogsExports: {&"some-log", &"some-other-log"},
            - 			Engine:                      &"some-engine",
            + 			Engine:                      nil,
            - 			EngineVersion:               &"some-engine-version",
            + 			EngineVersion:               nil,
            - 			KMSKeyID:                    &"some-key",
            + 			KMSKeyID:                    nil,
            - 			MasterUsername:              &"some-user",
            + 			MasterUsername:              nil,
              			Port:                        &3210,
              			PreSignedURL:                &"some-url",
            - 			PreferredBackupWindow:       &"some-window",
            + 			PreferredBackupWindow:       nil,
            - 			PreferredMaintenanceWindow:  &"some-window",
            + 			PreferredMaintenanceWindow:  nil,
            - 			StorageEncrypted:            &true,
            + 			StorageEncrypted:            nil,
              			Tags:                        {&{Key: &"some-tag-key", Value: &"some-tag-value"}, &{Key: &"some-other-tag-key", Value: &"some-other-tag-value"}},
              			VPCSecurityGroupIDs:         {&"some-group", &"some-other-group"},
              			CustomDBClusterParameters:   {MasterUserPasswordSecretRef: &{SecretReference: {Name: "some-name"}, Key: "some-key"}},
              		},
              	},
              	Status: {ResourceStatus: {ConditionedStatus: {Conditions: {{Type: "Ready", Status: "False", LastTransitionTime: s"2021-12-14 20:08:16.591356 +0100"..., Reason: "Creating"}}}}, AtProvider: {DBClusterARN: &"some-db-cluster-arn", DBClusterIdentifier: &"some-db-cluster", Endpoint: &"some-endpoint", ReaderEndpoint: &"some-reader-endpoint", ...}},
              }
        /Users/haarchri/Documents/test/provider-aws/pkg/controller/docdb/dbcluster/setup_test.go:2206: r: -want, +got:
              managed.ExternalCreation{
              	ExternalNameAssigned: false,
              	ConnectionDetails: managed.ConnectionDetails{
              		... // 2 identical entries
              		"port":           {0x33, 0x32, 0x31, 0x30},
              		"readerEndpoint": {0x73, 0x6f, 0x6d, 0x65, ...},
              		"username": {
            - 			0x73,
            - 			0x6f,
            - 			0x6d,
            - 			0x65,
            - 			0x2d,
            - 			0x75,
            - 			0x73,
            - 			0x65,
            - 			0x72,
              		},
              	},
              }
FAIL
FAIL	github.com/crossplane/provider-aws/pkg/controller/docdb/dbcluster	0.351s
FAIL

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Signed-off-by: haarchri <chhaar30@googlemail.com>
@haarchri haarchri requested review from muvaf and removed request for muvaf December 14, 2021 18:40
@haarchri haarchri marked this pull request as draft December 14, 2021 19:04
@haarchri
Copy link
Member Author

fixed with. #1111

@haarchri haarchri closed this Jan 31, 2022
tektondeploy pushed a commit to gtn3010/provider-aws that referenced this pull request Mar 12, 2024
…t-lambda-permission

fix(late-init): Lambda Permission: statement_id_prefix late initialization problem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant