rds: Add DBInstanceRoleAssociation #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlunde
force-pushed
the
db-role
branch
2 times, most recently
from
57df669
to
9b90828
Compare
|
mutating the resource is not supported (changing feature name or role ARN) when deleting, it "hangs" for a while as it takes a while to remove the role. Not sure if there's something we can do about this |
Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
Fix the IsNotFound handler so we can delete the RDS instance before the role. Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add DBInstanceRoleAssociation
Fixes #851
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Add resource, check console. Remove resource, check console.