Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(InstanceProfile): Add IAM InstanceProfile Managed Resource #1159

Merged
merged 4 commits into from
Mar 8, 2022
Merged

feat(InstanceProfile): Add IAM InstanceProfile Managed Resource #1159

merged 4 commits into from
Mar 8, 2022

Commits on Mar 7, 2022

  1. InstanceProfile ACK generation 

    Regenerate without Region

Commit iam generator-config

make generate result

Setup Controller and Register CRD

Fix imports and compile

Regenerate not requiring InstanceProfileName within the spec

Fix externalname and readiness, provide example

Generate rolereference

Fix field capitalization

Hook into postCreate to call AddRoleToInstanceProfile

Handle deletion and update examples

Signed-off-by: Yury Tsarev <yury@upbound.io>
    @ytsarev
    ytsarev committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    1150487 View commit details
    Browse the repository at this point in the history

  2. Fix linting 

    Signed-off-by: Yury Tsarev <yury@upbound.io>
    @ytsarev
    ytsarev committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    ef890f7 View commit details
    Browse the repository at this point in the history

  3. Rebase with crossplane-contrib#1122, make reviewable green 

    Signed-off-by: Yury Tsarev <yury@upbound.io>
    @ytsarev
    ytsarev committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    f5e5a2a View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Christopher Haar <chhaar30@googlemail.com>
Signed-off-by: Yury Tsarev <yury@upbound.io>
    @ytsarev @haarchri
    ytsarev and haarchri committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    24c367e View commit details
    Browse the repository at this point in the history