Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cognito/resource server #1217

Merged

Conversation

febarbosa182
Copy link
Contributor

Description of your changes

Adds support for resource server on AWS Cognito to allow client credentials flow.
This functionality is mentioned in #1216

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

This code has been tested manually tested against AWS using Kind running provider-aws locally out-of-cluster.

@haarchri
Copy link
Member

@haarchri
Copy link
Member

haarchri commented Mar 18, 2022

@febarbosa182 thanks for updating - can you Check your DCO Signing for the latest commit ?

@haarchri
Copy link
Member

@febarbosa182 thanks for adding example can you use rebase instead of merge ? Keeps the History clean

Signed-off-by: Felipe Barbosa <lybrbarbosa@gmail.com>
Signed-off-by: Felipe Barbosa <lybrbarbosa@gmail.com>
Signed-off-by: Felipe Barbosa <lybrbarbosa@gmail.com>
@febarbosa182
Copy link
Contributor Author

Thanks @haarchri for all your support in this issue and sorry for late update

Copy link
Member

@haarchri haarchri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested the resource LGTM thanks for the enhancement

@haarchri haarchri merged commit c4680f7 into crossplane-contrib:master May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants