fix(cognitoidentityprovider): Remove nil pointer exceptions in isUpTo… #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Date checks Signed-off-by: Benedikt Bock <benedikt.bock-extern@deutschebahn.com> (external expert on behalf of DB Netz AG)
Benedikt1992
force-pushed
the
fix_userpool
branch
from
1567258
to
3a543cd
Compare
|
Hey @Benedikt1992 thanks for the fix did you think that this also fixes the following issue ? https://crossplane.slack.com/archives/CEG3T90A1/p1652387657370869?thread_ts=1652376284.052839&cid=CEG3T90A1 |
Yes, this is the same bug |
|
Backport failed for Please cherry-pick the changes locally. |
febarbosa182
pushed a commit
to febarbosa182/provider-aws
that referenced
this pull request
May 23, 2022
…Date checks (crossplane-contrib#1300) Signed-off-by: Benedikt Bock <benedikt.bock-extern@deutschebahn.com> (external expert on behalf of DB Netz AG) Signed-off-by: Felipe Barbosa <lybrbarbosa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
The
UserPoolresource incognitoidentityprovidertries to resolve some nil pointers during theisUpToDatecheck. This PR checks if the pointers are nil.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
manual tests