GitHub-1286 fix late init dbinstance #1322
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Exclude deletion protection if dbinstance is a cluster member
Fixes #1286
I have:
make reviewable test
to ensure this PR is ready for review.make test
results inpackage github.com/crossplane/provider-aws/pkg/clients/mock: build constraints exclude all Go files in /Users/josephweigl/git/github/crossplane/provider-aws/pkg/clients/mock
make reviewable
results inHow has this code been tested
Build the provider and deployed it in our test environment.
This changes has fixed the deletionProtection issue which cases the dbinstance to be synced false