Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub-1286 fix late init dbinstance #1322

Conversation

eloo-abi
Copy link
Contributor

Description of your changes

Exclude deletion protection if dbinstance is a cluster member

Fixes #1286

I have:

  • [/] Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

make test results in package github.com/crossplane/provider-aws/pkg/clients/mock: build constraints exclude all Go files in /Users/josephweigl/git/github/crossplane/provider-aws/pkg/clients/mock

make reviewable results in

18:54:58 [ .. ] Generating sfn controllers and CRDs
Error: open /Users/josephweigl/.cache/ack-generate/src/aws-sdk-go/models/apis/servicecatalog-appregistry/2020-06-24/api-2.json: too many open files

How has this code been tested

Build the provider and deployed it in our test environment.
This changes has fixed the deletionProtection issue which cases the dbinstance to be synced false

Signed-off-by: Joseph Weigl <joseph.weigl@audi.de>
…stance is cluster member

Merge in OSSC/provider-aws from bugfix/GITHUB-1286-fix-late-init-dbinstance to GITHUB-1286-fix-late-init-dbinstance

* commit '765bfc207db6116357d65dbea4c805e85465bbfd':
  Exclude DeletionProtection if dbinstance is cluster member
@eloo-abi eloo-abi changed the title GitHub 1286 fix late init dbinstance GitHub-1286 fix late init dbinstance May 25, 2022
Copy link
Member

@haarchri haarchri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM we will backport this fix to 0.27 and will cut shortly 0.27.1 with a other PRs

@haarchri
Copy link
Member

@eloo-abi are you working with Mac ? You can try ulimit -n 10240

@haarchri haarchri merged commit c4dcbe0 into crossplane-contrib:master May 25, 2022
@github-actions
Copy link

Backport failed for release-0.27, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-0.27
git worktree add -d .worktree/backport-1322-to-release-0.27 origin/release-0.27
cd .worktree/backport-1322-to-release-0.27
git checkout -b backport-1322-to-release-0.27
ancref=$(git merge-base 04aa288fe1d8d888aa4c07e584f3f2525c1bbb66 441bfd29a9a06bd878f98c33dcce6023bb822dc7)
git cherry-pick -x $ancref..441bfd29a9a06bd878f98c33dcce6023bb822dc7

@eloo
Copy link

eloo commented May 30, 2022

@haarchri
thanks for the hint.. with the ulimit at least reviewable is working.

test is still failing:

package github.com/crossplane/provider-aws/pkg/clients/mock: build constraints exclude all Go files in /Users/josephweigl/git/github/crossplane/provider-aws/pkg/clients/mock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DBInstance: Late Initialize all fields that cannot be set when connecting to a DBCluster
3 participants