fix(LogGroup): Fix observe in case of more than 50 loggroups #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xists Signed-off-by: Petter Jacobsen <petteja@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
DescribeLogGroup returns maximum 50 loggroups pr default, which can lead to cases where loggroup exists but doesn't get returned and Crossplane will then attempt to create the resource, rather than taking ownership of the loggroup.
This adds the external name as LogGroupNamePrefix to the Describe call which will return loggroups that has external name as prefix.
Fixes #1188
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
This has been tested out of cluster and also in our test- and production environments.