providerconfig: make sure v1 auth path checks for assumeRole field as… #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… well Signed-off-by: Muvaffak Onus <me@muvaf.com>
|
i can test this later today in our environment and give feedback - thanks |
|
fix is working in our Environment tested kms key, eks addon and vpc endpoint |
haarchri
approved these changes
Jun 6, 2022
|
@haarchri thank you! |
|
Successfully created backport PR #1344 for |
|
Successfully created backport PR #1345 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #1334
Fixes #1289
Fixes #1278
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
make reviewable. I don't have the setup for IRSA at the moment. @haarchri Would you mind testing this with a v1 resource?