fix route53 wildcard handling

[nabuskey]

Signed-off-by: Manabu Mccloskey manabu.mccloskey@gmail.com

Description of your changes

Route53 does not return the * character if it sees it as a wildcard. e.g. For a record *.crossplane.io, the string for its name returned by Route53 API is \052.crossplane.io.

https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/DomainNameFormat.html?shortFooter=true#domain-name-format-asterisk

Fixes #1115

I have:

• Read and followed Crossplane's contribution process.
• Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Ran this code against my private Route53 zone with the following yaml:

apiVersion: route53.aws.crossplane.io/v1alpha1
kind: ResourceRecordSet
metadata:
  name: 'test-dns'
  annotations:
    crossplane.io/external-name: "*.crossplane.manabu.com"
spec:
  forProvider:
    type: A
    ttl: 300
    zoneId: <ZONEID>
    resourceRecords:
    - value: 1.2.3.4
  providerConfigRef:
    name: aws-provider-config

It used to never reach the ready state.

Normal   PendingExternalResource      24m (x3 over 24m)  managed/resourcerecordset.route53.aws.crossplane.io  Waiting for external resource existence to be confirmed

After the change, it correctly reaches the ready state.

[haarchri]

LGTM thanks for taking care