enhance existing Glue resources

[wotolom]

Description of your changes

changes for the existing AWS Glue resources SecurityConfiguration, Database, Connection, Classifier, Crawler and Job

Fixes #1304

Add lateInitialize, isUpToDate and update functionality where applicable
Add missing fields and referencers
StyleFix! several fieldnames

While adding missing fields and referencers/selectors, the opportunity arose to harmonize several existing fieldnames.
Here are these Breaking Changes:

• Job:
  • roleArn to role (same for roleRef, roleSelector)
• SecurityConfiguration:
  • for all encryptions (cloudWatchEncryption, jobBookmarksEncryption, s3Encryption):
    • kmsKeyARN to kmsKeyArn (add kmsKeyArnRef, kmsKeyArnSelector)
• Connection:
  • securityGroupIDList to securityGroupIdList (same for securityGroupIdRefs, securityGroupIdSelector)
  • subnetID to subnetId (same for subnetIdRef, subnetIdSelector)
• Crawler:
  • roleArn to role (same for roleRef, roleSelector)
  • for s3Targets:
    • dlqEventQueueARN to dlqEventQueueArn (add dlqEventQueueArnRef/dlqEventQueueArnSelector)
    • eventQueueARN to eventQueueArn (add eventQueueArnRef/eventQueueArnSelector)

People, who already used any of these Glue resources in an older crossplane version, would need to change the mentioned fieldnames in their Claims (XRCs), Compositions, XRDs etc.

Notes:

• Because this ACK-Issue was resolved, I could reimplement the Schedule field as intended. :)
• Because of this ACK-Issue I encountered, I had to set time-related fields for Status.AtProvider manually in postObserve.

I have:

• Read and followed Crossplane's [contribution process].
• Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

All 6 resources were tested manually (create, update, delete) with the objects in examples/glue.

[haarchri]

@wotolom can you cleanup the examples ?

[wotolom]

Hi @haarchri, are the examples ok now?

[haarchri]

Thanks for this enhancement - the only open part are the fields with breaking changes for folks using glue stuff - for now it would be betternot changing so many existing fields - what do you think ? We can do this with migration hook support in the future

[wotolom]

Thanks for the review!

About the breaking changes:
The prior implementations of the Glue resources were not really complete, but of course already to some degree productively usable.
I still think now (with this merge) would be a good time to make these changes as the number of people who use the Glue service will only grow. And for the versioning it may be simpler to have these changes coupled together with this enhancement.

However I'm of course a bit biased. (contributing and future use) ;)

[haarchri]

@wotolom sounds great - can you add all breaking changes for release notes that would be great

[haarchri]

thanks for Implementation - tested all glue resources