rdsinstance: AWS Backup might also manage PreferredBackupWindow #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have special case handling for BackupRetentionPeriod when AWS Backup is enabled. Add similar handling for PreferredBackupWindow. This attribute is ready only when AWS Backup is enabled. We run into issues like this because of late initialization which sets fields into the spec which in some cases are more like status fields. Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
haarchri
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
We already have special case handling for BackupRetentionPeriod when AWS
Backup is enabled. Add similar handling for PreferredBackupWindow. This
attribute is ready only when AWS Backup is enabled.
We run into issues like this because of late initialization which sets
fields into the spec which in some cases are more like status fields.
Related: #1356
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested