Updated Handling of DBCluster Update #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 12, 2022 13:02
Signed-off-by: André Kesser <andre.kesser@dkb.de>
Signed-off-by: André Kesser <andre.kesser@dkb.de>
haarchri
reviewed
Aug 12, 2022
Signed-off-by: André Kesser <andre.kesser@dkb.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Updated the handling of DBCluster updates, now several properties are taken into account when checking if an update is needed:
Deletion of a Cluster is updated to not send FinalDBSnapshotIdentifier and SkipFinalSnapshot at the same time: if SkipFinalSnapshot is set to true, FinalDBSnapshotIdentifier is skipped
Fixes #1423
Fixes #1421
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested manually
[contribution process]: https://git.io/fj2m9