Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore DBCluster from S3 snapshot #1428

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Restore DBCluster from S3 snapshot #1428

merged 1 commit into from
Aug 23, 2022

Conversation

AlexLast
Copy link
Contributor

@AlexLast AlexLast commented Aug 16, 2022

Signed-off-by: Alex Last alexrichardlast@gmail.com

Description of your changes

Fixes #1085

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

  • Tested running this build locally
  • Tested existing create cluster logic works as expected and creates new DBCluster in AWS
  • Tested new restore logic works as expected and restores a new DBCluster in AWS
  • Tested observe stages update resource status as expected, when restore is complete

Signed-off-by: Alex Last <alexrichardlast@gmail.com>
@haarchri
Copy link
Member

thanks for implementation - one question regarding our discussion in slack - is creation working without errors ?

@AlexLast
Copy link
Contributor Author

thanks for implementation - one question regarding our discussion in slack - is creation working without errors ?

@haarchri As expected there is a single error event stating the resource already exists - after preCreate returns and the Create function continues with the usual logic.

Subsequent reconciliations with the observe phase work as expected. Unfortunately as long as preCreate doesn't return an error, Create will continue, and we will get this single error when restoring a DBCluster for the first time.

@haarchri
Copy link
Member

Thanks for clarification

@haarchri
Copy link
Member

Can you rebase master ? We had a few MRs in RDS area

Copy link
Member

@haarchri haarchri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for Implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore RDS instance from a MySQL backup for DBInstance in RDS Group
2 participants