Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed generation of flowlog #1429

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

akesser
Copy link
Contributor

@akesser akesser commented Aug 17, 2022

Signed-off-by: André Kesser andre.kesser@dkb.de

Description of your changes

Due to a mismatching upper and lowercase letters, the DeliverLogsPermissionArn property was not filled when creating a flow log. This pull request fixes this.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Tested manually

Signed-off-by: André Kesser <andre.kesser@dkb.de>
Copy link
Member

@haarchri haarchri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested - thanks for fixing this - we will cut a backport release for 0.30 as well

@haarchri haarchri merged commit 11c2123 into crossplane-contrib:master Aug 17, 2022
@github-actions
Copy link

Successfully created backport PR #1430 for release-0.30.

@akesser akesser deleted the feature/flowlog-fix branch August 17, 2022 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants