Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/secrets encryption #1450

Merged

Conversation

akesser
Copy link
Contributor

@akesser akesser commented Aug 25, 2022

Description of your changes

As described by @haarchri, a call to AssociateEncryptionConfig was added

Fixes #1021

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

tested manually
[contribution process]: https://git.io/fj2m9

André Kesser added 4 commits August 25, 2022 07:47
Signed-off-by: André Kesser <andre.kesser@dkb.de>
Signed-off-by: André Kesser <andre.kesser@dkb.de>
Signed-off-by: André Kesser <andre.kesser@dkb.de>
Signed-off-by: André Kesser <andre.kesser@dkb.de>
@haarchri haarchri marked this pull request as ready for review August 25, 2022 06:16
Copy link
Member

@haarchri haarchri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haarchri haarchri merged commit 70879e6 into crossplane-contrib:master Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EKS Secrets Encryption cannot be enabled after cluster creation
2 participants