Fixes an issue with S3 notifications

[stunthamster]

Signed-off-by: Michael Duffy mike@stunthamster.com

Description of your changes

This PR fixes an issue where SNS notifications cannot be added to S3 buckets using topicRef names. Currently, the topicRef attempts to find a SNSTopic object from the deprecated notification.aws.crossplane.io API group. This PR changes it to use the correct SNS API group.

I have:

• [ x] Read and followed Crossplane's contribution process.
• [ x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

N/A

[haarchri]

LGTM

[haarchri]

@muvaf can we merge it ? How do you feel about it because of deprecation of notification? we will hold the next release v0.32.0 till we make a discission

[nabuskey]

With this change, existing resources using SNS notification will not be affected as long as resolution policy is set to IfNotPresent. New resources, however, will not have references to the SNS topic resource. So composition for that will need to be updated.

Looks like SNSTopic was marked deprecated 8 months ago. Is there a timeline for removing this api group?

[haarchri]

i am fine to say in v0.33.0 to make this change and remove the old apiGroup - depends on the others =)

[haarchri]

we will remove with provider release v0.33.0 at Oct 19, 2022 the depcrecated notification APIGroup - and will merge this PR !!!
#1502