Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove notification APIGroup #1506

Merged

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented Oct 2, 2022

Description of your changes

  • remove deprecated notification APIGroup
  • added resolvers for NotificationTopicARN cache APIGroup and switched if possible to generated resolvers for SNS
  • added resolvers for NotificationTopicARN dax APIGroup for SNS

preparation for #1502

Remove CRDs from Cluster:

kubectl delete crd snssubscriptions.notification.aws.crossplane.io 
customresourcedefinition.apiextensions.k8s.io "snssubscriptions.notification.aws.crossplane.io" deleted
kubectl delete crds snstopics.notification.aws.crossplane.io
customresourcedefinition.apiextensions.k8s.io "snstopics.notification.aws.crossplane.io" deleted

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

  • create, update, delete Cache Cluster, SubnetGroup, ReplicationGroup
  • create, update, delete DAX Cluster

Signed-off-by: haarchri <chhaar30@googlemail.com>
Signed-off-by: haarchri <chhaar30@googlemail.com>
Signed-off-by: haarchri <chhaar30@googlemail.com>
Copy link
Contributor

@ezgidemirel ezgidemirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @haarchri for the cleanup and new resources :)

@haarchri haarchri requested a review from chlunde October 3, 2022 18:04
@chlunde
Copy link
Collaborator

chlunde commented Oct 3, 2022

Maybe (if you have time) add a text for the release notes with a bit more info.

"resource <X,Y,..> was removed due to and after being deprecated since . The replacement resource is " To see if you are using this resource, run "kubectl X".

To avoid downtime, convert new resources before upgrading.
The new resources <have the same schema|a different schema, field f1 is now called f2>

of course it depends on how much time you have :)

I think @muvaf had a good text for the IAMRole -> Role.IAM change.

@haarchri
Copy link
Member Author

haarchri commented Oct 3, 2022

we will add again the migration text

Thanks ;)

@haarchri haarchri merged commit 53d3fbe into crossplane-contrib:master Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants