Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sg): added example for ipProtocol -1 #1508

Merged

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented Oct 2, 2022

Signed-off-by: haarchri chhaar30@googlemail.com

Description of your changes

added example for securityGroup with ipProtocol: -1

Fixes #1400 #1138

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

kubectl get managed
NAME                                                    READY   SYNCED   ID                     VPC                     AGE
securitygroup.ec2.aws.crossplane.io/db-security-group   True    True     sg-099d50bb8084771f4   vpc-03359a2baaabf1704   12s
securitygroup.ec2.aws.crossplane.io/sample-cluster-sg   True    True     sg-08e483bec56b040fa   vpc-03359a2baaabf1704   12s

NAME                                    READY   SYNCED   ID                      CIDR          IPV6CIDR   AGE
vpc.ec2.aws.crossplane.io/sample-vpc    True    True     vpc-03359a2baaabf1704   10.0.0.0/16              33s
vpc.ec2.aws.crossplane.io/sample-vpc2   True    True     vpc-0b4bd7ed41c99a778   10.1.0.0/16              33s

@haarchri haarchri requested a review from chlunde October 2, 2022 12:13
Signed-off-by: haarchri <chhaar30@googlemail.com>
@haarchri haarchri merged commit f20c716 into crossplane-contrib:master Oct 2, 2022
@haarchri haarchri deleted the feature/sg-examples-ipprotocol branch October 2, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SecurityGroup stuck in Ready: false
2 participants