Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove depcreation for providers #1509

Merged

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented Oct 2, 2022

Signed-off-by: haarchri chhaar30@googlemail.com

Description of your changes

  • remove provider v1alpha3 Resource

preparation for #1502

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Signed-off-by: haarchri <chhaar30@googlemail.com>
@haarchri haarchri changed the title feat(providers): remove depcreation for providers and int32ptr remove depcreation for providers and int32ptr Oct 2, 2022
@haarchri
Copy link
Member Author

haarchri commented Oct 2, 2022

@hasheddan @muvaf did we need an additional runtime update if we want to remove provider ?

apiVersion: aws.crossplane.io/v1alpha3
kind: Provider

@haarchri haarchri changed the title remove depcreation for providers and int32ptr WIP: remove depcreation for providers and int32ptr Oct 2, 2022
Signed-off-by: haarchri <chhaar30@googlemail.com>
@haarchri haarchri changed the title WIP: remove depcreation for providers and int32ptr WIP: remove depcreation for providers Oct 4, 2022
Signed-off-by: haarchri <chhaar30@googlemail.com>
@haarchri haarchri changed the title WIP: remove depcreation for providers remove depcreation for providers Oct 4, 2022
Copy link
Member

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @haarchri!

@haarchri haarchri merged commit eaf99fb into crossplane-contrib:master Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants