Add docs for SecurityGroupRule to fix #1516 #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bastien Grasnick <bastien.grasnick@deutschebahn.com>
Signed-off-by: Bastien Grasnick <bastien.grasnick@deutschebahn.com>
…tyGroupId as well Signed-off-by: Bastien Grasnick <bastien.grasnick@deutschebahn.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR increases the documentation for SecurityGroupRules by adding an important hint to securityGroupId.
Without it users might miss that they need to set the option ignoreIngress and/or ignoreEgress and it will lead to repeated recreation of SecurityGroupRules.
Fixes #1516
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Will be tested by running locally with
make run(on behalf of DB Systel GmbH)