fix(cognito/userpool)!: MFA not always working #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wotolom
force-pushed
the
cognito-user-pool-mfa-fix
branch
from
588201c
to
1624b0a
Compare
MisterMX
requested changes
Oct 27, 2022
wotolom
force-pushed
the
cognito-user-pool-mfa-fix
branch
from
1624b0a
to
af13bb0
Compare
|
@wotolom can you rebase ? we fixed the CI issue with check-diff |
wotolom
force-pushed
the
cognito-user-pool-mfa-fix
branch
from
af13bb0
to
beb2253
Compare
|
@MisterMX you requested changes so i unable to merge the PR |
MisterMX
requested changes
Nov 7, 2022
-add field SoftwareTokenMFAConfiguration -remove deprecated UnusedAccountValidityDays -enhance several controller parts Signed-off-by: Charel Baum <charel.baum@accenture.com>
wotolom
force-pushed
the
cognito-user-pool-mfa-fix
branch
from
beb2253
to
83bfe4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
SoftwareTokenMFAConfiguration(+ handling throughSetUserPoolMfaConfigWithContext)AdminCreateUserConfig.UnusedAccountValidityDaysisUptoDate-checks for not updatable fieldslateInitializesome fieldsFixes #1499
While fixing the MFA issue, I came across some smaller, missed edge cases, which I fixed/implemented.
One of these is a Breaking Change: the removal of the deprecated field
adminCreateUserConfig.unusedAccountValidityDays.Terraform already eliminated the deprecated field. (hashicorp/terraform-provider-aws#14294)
Users using
adminCreateUserConfig.unusedAccountValidityDayswill have to usepolicies.passwordPolicy.temporaryPasswordValidityDaysinstead.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Manually with the relating example.
Minimal addition to setup_test.go.