feat(kafka): Add update function for cluster

[akesser]

Description of your changes

We implemented the functions to update a Kafka cluster

fixes the update of a Kafka cluster as mentioned in #1683

I have:

• Read and followed Crossplane's contribution process.
• Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Tested locally against aws account

[haarchri]

@akesser can you Check for DCO ?

[MisterMX]

@akesser could you unwrap the ifs into a more linear form. Otherwise the code is too hard to read. Also you might want to checkout cmp.Equal to see if can help you to save some of that code.

[akesser]

According to its self description, cmp.Equal is not meant to be used in production:

This package is intended to be a more powerful and safer alternative to reflect.DeepEqual for comparing whether two values are semantically equal. It is intended to only be used in tests, as performance is not a goal and it may panic if it cannot compare the values. Its propensity towards panicking means that it's unsuitable for production environments where a spurious panic may be fatal. (from: https://pkg.go.dev/github.com/google/go-cmp/cmp#pkg-overview)

In my opinion, the used ifs is the best way to keep the code readable, keeping it clear what property is under test right now. Using linearized forms of ifs requires many repetitions, making it hard to see the difference in the if to the previous and following test.

The code in other files also uses nested ifs, not to mention auto generated code.

[MisterMX]

@akesser cmp.Equal is used extensively in this provider and in many others as well. The performance hit, if noticable at all, is negliable because the API calls take much more time. Since we know all of the types that we want to compare it is safe to assume that they will be comparable.

What counts is source code readability and multiple nested ifs aren't exactly that. It might be that other controllers do that but that doesn't make it any more readable.

It would be really great if you could simplify the code by using it.

[akesser]

Additionally to the warning, that cmp.Equal should not be used, the different naming of some properties, like IAM vs Iam or EBSStorageInfo vs. EbsStorageInfo would lead to either ignoring them in cmp.Equal and comparing them by hand again or writing transformers that do the same comparison the code already does.

[MisterMX]

That's correct, the common way is to create a *svcapitypes.LoggingInfo from the *svcsdk.LoggingInfo so compare two objects of the same type.

[haarchri]

think the code is Not easier to read when switching to cmp.Equal

[MisterMX]

Alright, then its decided. Thank you for your contribution @akesser!