Handle VPCCIDRBlock delete case in Observe #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
The VPCCIDRBlock association is never actually removed from the VPC when the VPCCIDRBlock is deleted, it is put into the
disassociatedstate where it remains until the VPC is deleted.This change modifies the Observe function to check to see if the managed resource has been deleted when it finds the VPCCIDRBlock is in the
disassociatedstate and returnResourceExists: falseso that the reconciler will remove the finalizer and allow the MR to be deleted.Fixes #1729
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Verified that the VPCCIDRBlock resource is deleted properly when this fix is applied.