Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FilterPolicyScope SNS property #1737

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

torrescd
Copy link

@torrescd torrescd commented Apr 24, 2023

Description of your changes

Add FilterPolicyScope SNS property

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Tested on custom image devopsmindset/provider-aws:v0.0.0-2805.gc24807d8 with proper sns

Signed-off-by: Torrescusa, Daniel {DISB~Sant Cugat Dia} <daniel.torrescusa@roche.com>
@chlunde
Copy link
Collaborator

chlunde commented Apr 24, 2023

Thanks, tested OK:

apiVersion: sns.aws.crossplane.io/v1beta1
kind: Subscription
metadata:
  name: sample-subscription
spec:
  forProvider:
    region: us-east-1
    protocol: email
    filterPolicyScope: MessageBody
    filterPolicy: |
       {
         "foo": ["bar"]
       }
    endpoint: crossplane-test@mailinator.com
    topicArnRef:
      name: some-topic
  providerConfigRef:
    name: example

@haarchri haarchri merged commit 7bb6fbf into crossplane-contrib:master Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants