fix(s3) compare unmarshaled policy #1758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tom1893 thank you so much for your contribution. Please add unit tests to verify that your changes are actually working and sign and squash your commits. Thanks in advance. |
|
Hi @Tom1893, Are we able to push this changes soon? |
Signed-off-by: Tom Dott (external expert on behalf of DB Netz AG) <tom.dott@deutschebahn.com> fix(s3) add command to JSONNormalize add unit test for policy fix format fix format format
Tom1893
force-pushed
the
fix-updateloop-in-bucketpolicy
branch
from
f4eec87
to
36b4db9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
In the observe policy in the bucket, the comparison of JSON strings was changed to the comparison between actual JSON objects to prevent the update loop. This way it recognizes that the two objects are the same.
We love pull requests that resolve an open Crossplane issue. If yours does, you
can uncomment the below line to indicate which issue your PR fixes, for example
"Fixes #500":
-->
Fixes #1757
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested