Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docdb): Add restore from snapshot and point in time #1763

Conversation

safboukhari
Copy link
Contributor

@safboukhari safboukhari commented May 23, 2023

Description of your changes

This adds AWS restore features for DocumentDB to DBCluster. Restore works in the same way as for RDS.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Unit tests and the existing examples.

@safboukhari safboukhari force-pushed the implement_point_in_time_restore_for_docdb branch from 56b371c to 6b8b2bf Compare May 23, 2023 11:38
@safboukhari safboukhari marked this pull request as ready for review May 23, 2023 11:40
apis/docdb/v1alpha1/custom_types.go Outdated Show resolved Hide resolved
apis/docdb/v1alpha1/custom_types.go Outdated Show resolved Hide resolved
apis/docdb/v1alpha1/custom_types.go Outdated Show resolved Hide resolved
apis/docdb/v1alpha1/custom_types.go Outdated Show resolved Hide resolved
apis/docdb/v1alpha1/custom_types.go Outdated Show resolved Hide resolved
apis/docdb/v1alpha1/custom_types.go Outdated Show resolved Hide resolved
apis/docdb/v1alpha1/custom_types.go Outdated Show resolved Hide resolved
@safboukhari safboukhari force-pushed the implement_point_in_time_restore_for_docdb branch 2 times, most recently from 1a14efd to f6c38f7 Compare May 25, 2023 14:53
apis/docdb/v1alpha1/custom_types.go Outdated Show resolved Hide resolved
@MisterMX MisterMX force-pushed the implement_point_in_time_restore_for_docdb branch 2 times, most recently from d67688d to 3f67acd Compare May 31, 2023 14:51
@MisterMX MisterMX changed the title feat(DocDB): implement restorefrom for docdb feat(docdb): Add restore from snapshot and point in time May 31, 2023
@MisterMX
Copy link
Collaborator

I added some changes to the branch. @haarchri or @chlunde can you take a look a second look at it?

@MisterMX MisterMX force-pushed the implement_point_in_time_restore_for_docdb branch from 3f67acd to f0475f6 Compare May 31, 2023 15:41
@haarchri
Copy link
Member

@safboukhari @MisterMX please rebase and solve conflicts

@MisterMX MisterMX force-pushed the implement_point_in_time_restore_for_docdb branch from f0475f6 to d1b663f Compare June 13, 2023 15:27
Co-authored-by: Maximilian Blatt <maximilian.blatt-extern@deutschebahn.com>

Signed-off-by: safboukhari <safae.boukhari@bluestone-tec.com>
(external expert on behalf of DB Netz AG)
Signed-off-by: Maximilian Blatt (external expert on behalf of DB Netz) <maximilian.blatt-extern@deutschebahn.com>
@MisterMX MisterMX force-pushed the implement_point_in_time_restore_for_docdb branch from d1b663f to 05d7a2f Compare June 13, 2023 15:39
@haarchri haarchri merged commit 594d12c into crossplane-contrib:master Jun 13, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants