feat(kafka): Support cross account access #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
chlunde
approved these changes
Oct 6, 2023
|
I see lint due to k8 utils pointer just "fails green" due to other issues in other builds, while this PR the linter ran to completion and reported the error. |
MisterMX
force-pushed
the
feat/kafka-cross-account-access
branch
2 times, most recently
from
306b4f0
to
3b426e3
Compare
Add cluster policy and connectivity properties that allow configuring cross account accessibility of a broker. Signed-off-by: Maximilian Blatt (external expert on behalf of DB Netz) <maximilian.blatt-extern@deutschebahn.com>
MisterMX
force-pushed
the
feat/kafka-cross-account-access
branch
from
3b426e3
to
6483a76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds cluster policy and connectivity properties that allow configuring cross account accessibility of a broker.
It is mostly copy-paste from the specialized bucket policy types into a generic
ResourcePolicystruct and a bunch of late initialization and conversion methods.It also fixes a bug that
spec.forProvider.encryptionInfowas not late initialized properly which led to an error during updates.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Using the existing example.