fix(rds): Add missing tag updates #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maximilian Blatt (external expert on behalf of DB Netz) <maximilian.blatt-extern@deutschebahn.com>
chlunde
approved these changes
Oct 12, 2023
| @@ -104,6 +107,11 @@ type custom struct { | |||
| kube client.Client | |||
| client svcsdkapi.RDSAPI | |||
| external *external | |||
|
|
|||
| cache struct { | |||
There was a problem hiding this comment.
Have we done this anywhere else? I wonder if we have any guarantees that this will not be reused for other resources.
I think it is Ok..
There was a problem hiding this comment.
Yes, I have done this multiple times. Since the hook is created during Connect which is called in every reconcile, we can be sure that there is always a unique hook (or external) for every reconcile.
|
Successfully created backport PR #1905 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds missing tag comparisons and updates to
rds.DBClusterParameterGrouprds.DBParameterGrouprds.DBInstanceFixes #494
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Simple tag adds and removals using the already existing examples.