fix(dynamodb): Resolve KMSMasterKeyArn for comparison #1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisterMX
force-pushed
the
fix/dynamodb-kms-master-key-id
branch
from
d3d38e4
to
0463018
Compare
chlunde
reviewed
Oct 13, 2023
chlunde
approved these changes
Oct 13, 2023
MisterMX
force-pushed
the
fix/dynamodb-kms-master-key-id
branch
from
0463018
to
03cf1e6
Compare
Signed-off-by: Maximilian Blatt (external expert on behalf of DB Netz) <maximilian.blatt-extern@deutschebahn.com>
MisterMX
force-pushed
the
fix/dynamodb-kms-master-key-id
branch
from
03cf1e6
to
7cbb96b
Compare
|
Successfully created backport PR #1911 for |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This adds an extra step in
isUpToDateto resolve the ARN of the key that is referenced by whatever is given inspec.forProvider.sseSpecification.kmsMasterKeyId. This is necessary because AWS always returns the ARN even if the create or update call was made with an alias which triggered constant update calls.Fixes #1440
This uses Gomock to mock the KMS client. I the same step I added a bunch of refactoring, like moving all mocks in the same package and splitting the API code generation from mock code generation.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Unit tests and existing examples