Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Disable codeql step #1910

Merged

Conversation

MisterMX
Copy link
Collaborator

Description of your changes

Removes the codeql check that was introduced with #1888 because it takes a very long time to run and we are not using the results anywhere.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

n.a.

Signed-off-by: Maximilian Blatt (external expert on behalf of DB Netz) <maximilian.blatt-extern@deutschebahn.com>
@chlunde
Copy link
Collaborator

chlunde commented Oct 13, 2023

I think we could run it scheduled instead, or as part of the (pre)release-process

@MisterMX
Copy link
Collaborator Author

MisterMX commented Oct 13, 2023

I think we could run it scheduled instead, or as part of the (pre)release-process

This would be an option, but I am not sure, what we would currently do with the results... 😆

Anyway I am open for this change if somebody has a use case.

@MisterMX MisterMX merged commit 81ddd49 into crossplane-contrib:master Oct 13, 2023
9 checks passed
@github-actions
Copy link

Successfully created backport PR #1912 for release-0.44.

@MisterMX MisterMX deleted the chore/disable-ci-codeql branch October 19, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants