-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Move methods in pkg/clients/
into invidual util packages
#1917
refactor: Move methods in pkg/clients/
into invidual util packages
#1917
Conversation
Signed-off-by: Maximilian Blatt (external expert on behalf of DB Netz) <maximilian.blatt-extern@deutschebahn.com>
Signed-off-by: Maximilian Blatt (external expert on behalf of DB Netz) <maximilian.blatt-extern@deutschebahn.com>
Signed-off-by: Maximilian Blatt (external expert on behalf of DB Netz) <maximilian.blatt-extern@deutschebahn.com>
Signed-off-by: Maximilian Blatt (external expert on behalf of DB Netz) <maximilian.blatt-extern@deutschebahn.com>
Signed-off-by: Maximilian Blatt (external expert on behalf of DB Netz) <maximilian.blatt-extern@deutschebahn.com>
I think we should ensure that the replaced functions have identical behaviour, it will be very hard to test if any of these changes have negative side effects?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enssure we have identical behaviour for empty string vs nil
Signed-off-by: Maximilian Blatt (external expert on behalf of DB Netz) <maximilian.blatt-extern@deutschebahn.com>
Signed-off-by: Maximilian Blatt (external expert on behalf of DB Netz) <maximilian.blatt-extern@deutschebahn.com>
8e36efc
to
5a99273
Compare
Sorry, I think I messed something up while search-replacing the pointer methods. It should now work without any behavioral changes. |
Description of your changes
This moves the individual
pkg/clients/*.go
files into their ownpkg/utils/
packages to provide better modularization. It also makes imports a bit cleaner as thepkg/clients
was imported in the code with many different names (awsclients
,awsclient
,clients
,aws
etc.).There are no functional changes to the code. Only the imports have changed. In a very small amount of places the pointer function has been replaced with the respective one from
k8s.io/utils/ptr
.I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
n.a.