Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kafka/cluster): clusterpolicy update + delete #1921

Merged

Conversation

wotolom
Copy link
Contributor

@wotolom wotolom commented Oct 18, 2023

Description of your changes

For kafka.Cluster:

  • adaptation in getClusterPolicyState to allow triggering deletion of ClusterPolicy when user sets clusterPolicy: null in claim
  • cache the CurrentVersion of the ClusterPolicy to enable making consecutive PutClusterPolicy calls
    EDIT: add + use new field Status.AtProvider.ClusterPolicyVersion to "cache" the CurrentVersion of the ClusterPolicy for update. This way user has also access to that data, e.g. for making manual PutClusterPolicy calls.

Fixes #1920

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

manually

@wotolom wotolom force-pushed the kafka-cluster-clusterpolicy-update branch 2 times, most recently from 67ef42d to 96f4ed4 Compare October 18, 2023 14:13
Signed-off-by: Charel Baum (external expert on behalf of DB Netz AG) <charel.baum-extern@deutschebahn.com>
@wotolom wotolom force-pushed the kafka-cluster-clusterpolicy-update branch from 96f4ed4 to 3c3b18c Compare October 19, 2023 08:26
Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much @wotolom!

@MisterMX MisterMX merged commit b2583c6 into crossplane-contrib:master Oct 19, 2023
9 checks passed
@github-actions
Copy link

Successfully created backport PR #1922 for release-0.44.

@wotolom wotolom deleted the kafka-cluster-clusterpolicy-update branch November 13, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to update MSK cluster policy after creation
2 participants