feat(database): Pass CACertificateIdentifier during instance creation #1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0 so that CACertificateIdentifier is now supported as part of the CreateDBInstanceInput struct Signed-off-by: Trystan Leftwich <trystanleftwich@gmail.com>
MisterMX
changed the title
MisterMX
approved these changes
Oct 25, 2023
trystanleftwich
deleted the
feat/add-ca-certi-to-rds-create-db-instance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Updated github.com/aws/aws-sdk-go-v2/service/rds to v1.39.0 so that
CACertificateIdentifieris set atCreateDBInstancetime instead of having to wait for the firstModifyDBInstancewindow.Fixes #1931
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Created a new RDS instance to check that it passes in
CACertificateIdentifieras part of the CreateDBInstance API call.