feat(certificate): add key algorithm #1933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisterMX
requested changes
Oct 31, 2023
wotolom
force-pushed
the
acm-certificate-add-key-algorithm
branch
from
1712285
to
1167613
Compare
MisterMX
reviewed
Oct 31, 2023
added 2 commits
October 31, 2023 17:54
Signed-off-by: Charel Baum (external expert on behalf of DB Netz AG) <charel.baum-extern@deutschebahn.com>
Signed-off-by: Charel Baum (external expert on behalf of DB Netz AG) <charel.baum-extern@deutschebahn.com>
wotolom
force-pushed
the
acm-certificate-add-key-algorithm
branch
from
1167613
to
cec9c34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
for resource
acm.CertficateKeyAlgorithmThis allows users to set a different encryption algorithm than RSA_2048 for ACM certificates on creation.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
manually