feat(transfer): Support multiple public SSH keys #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate spec.forProvider.sshPublicKeyBody in favor of spec.forProvider.sshPublicKeys. Signed-off-by: Maximilian Blatt (external expert on behalf of DB Netz) <maximilian.blatt-extern@deutschebahn.com>
chlunde
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This adds support for multiple SSH keys per transfer user. It relies on
ImportSshPublicKeyinstead of passing a single key withCreateUser.It also adds support for tag updates.
Deprecate
spec.forProvider.sshPublicKeyBodyin favor ofspec.forProvider.sshPublicKeys.If
spec.forProvider.sshPublicKeysis nil it will be lateinitialized to an array with a single item containingspec.forProvider.sshPublicKeyBody(if not nil).This is technically not breaking as the field
spec.forProvider.sshPublicKeyBodyis immutable.However, it should be removed in a future release.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Manually with the (new) provided example and unit tests.