Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: firehose deliverystream controller check-diff #1943

Merged

Conversation

smcavallo
Copy link
Contributor

@smcavallo smcavallo commented Nov 10, 2023

Signed-off-by: smcavallo smcavallo@hotmail.com

Description of your changes

fixes check-diff failure in recent builds

  M pkg/controller/firehose/deliverystream/zz_controller.go
02:03:14 [FAIL] There are uncommitted changes after running make generate. Please ensure you commit all generated files in this branch after running make generate.
make: *** [build/makelib/common.mk:446: check-diff] Error 1
Error: Process completed with exit code 2.

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Signed-off-by: smcavallo <smcavallo@hotmail.com>
Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much @smcavallo!

@MisterMX MisterMX merged commit f4b5949 into crossplane-contrib:master Nov 10, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants