Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(database): Ignore immutable field DBName in isUpToDate #1957

Merged

Conversation

MisterMX
Copy link
Collaborator

Description of your changes

Ignores the immutable field spec.forProvider.dbName when generating the diff.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Signed-off-by: Maximilian Blatt (external expert on behalf of DB Netz) <maximilian.blatt-extern@deutschebahn.com>
@MisterMX MisterMX merged commit 4124fb7 into crossplane-contrib:master Nov 27, 2023
9 checks passed
@MisterMX MisterMX deleted the fix/database-dbname-loop branch November 27, 2023 12:29
Copy link

Successfully created backport PR #1961 for release-0.45.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants