Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eks): Fixes Update Loop when KubernetesNetworkConfig is Set. #1959

Conversation

amotolani
Copy link
Contributor

@amotolani amotolani commented Nov 23, 2023

Description of your changes

  • Adds KubernetesNetworkConfig to LateInitialize function
  • Updates LateInitialize Unit tests accordingly

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Unit Tests

Signed-off-by: David Adelowo <david.adelowo@bitso.com>
@amotolani amotolani changed the title Fixes Update Loop when KubernetesNetworkConfig is Set. fix(eks): Fixes Update Loop when KubernetesNetworkConfig is Set. Nov 23, 2023
Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much @amotolani!

@MisterMX MisterMX merged commit f446be0 into crossplane-contrib:master Nov 23, 2023
9 checks passed
Copy link

Successfully created backport PR #1960 for release-0.45.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants