fix(rdsinstance): Updates will now set ResourceCredentialsSecretUserKey in ConnectionDetails if masterUsername is set #2000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trystanleftwich
force-pushed
the
fix/rdsinstane-add-masterUsername-to-output-if-exists
branch
from
828fce1
to
2e35876
Compare
MisterMX
requested changes
Feb 14, 2024
|
@trystanleftwich can you rebase on the latest master to fix e2e tests? |
trystanleftwich
force-pushed
the
fix/rdsinstane-add-masterUsername-to-output-if-exists
branch
2 times, most recently
from
50b638f
to
45d8acb
Compare
@MisterMX I rebased but it didn't run the full suite it seems. Anyway to trigger a run? |
|
@trystanleftwich can you try squashing your changes into a single commit? |
…ey in ConnectionDetails if masterUsername is set Signed-off-by: Trystan Leftwich <trystanleftwich@gmail.com>
trystanleftwich
force-pushed
the
fix/rdsinstane-add-masterUsername-to-output-if-exists
branch
from
45d8acb
to
ef4c3af
Compare
MisterMX
approved these changes
Mar 15, 2024
|
Successfully created backport PR #2011 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
in rdsInstance when running an update always set
ResourceCredentialsSecretUserKeyin the ConnectionDetails if masterUsername exists.Fixes #1999
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Created an RDSInstance, Deleted it when deletionPolicy = Orphan.
Re-added the RDSInstance, checked the secret contained
username