fix(database): skip isUpToDate on deletion #2001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisterMX
requested changes
Feb 15, 2024
Comment on lines
164
to
165
| upToDate := true | ||
| diff := "" |
There was a problem hiding this comment.
Easier to read would be
Suggested change
| upToDate := true | |
| diff := "" | |
| if meta.WasDeleted(cr) { | |
| return managed.ExternalObservation{}, nil | |
| } | |
| var upToDate bool | |
| var diff string |
There was a problem hiding this comment.
good point!
Just added ResourceExists: true, else the MR is deleted without sending a deletion-call due to never reach Delete().
wotolom
force-pushed
the
fix-database-rdsinstance-skip-isuptodate-on-delete
branch
from
128fddc
to
cc0fe05
Compare
|
@wotolom can you rebase on the latest master to fix e2e tests? |
Signed-off-by: Charel Baum (external expert on behalf of DB InfraGO AG) <charel.baum-extern@deutschebahn.com>
wotolom
force-pushed
the
fix-database-rdsinstance-skip-isuptodate-on-delete
branch
from
cc0fe05
to
0754cc0
Compare
wotolom
deleted the
fix-database-rdsinstance-skip-isuptodate-on-delete
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
for
database.rdsinstance:This fixes e.g. a common case of a missing k8s secret blocking the deletion, if it was deleted from the cluster before the MR.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
manually