fix(s3 bucket): Ignore AWS system tags #2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kirill Sushkov (teeverr) <kirill.sushkov@swisscom.com>
|
Successfully created backport PR #2019 for |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Ignore s3 bucket systemd tags(with prefix
aws:) on observed resource side because these cannot be updated/deleted, otherwise it cause an errorExample: the controller takes control over existing s3 bucket which has systemd tag(s) and tries to reconcile tag set with desired state which doesn't include tags at all or regular tags only. As result the controller gets an error due it is impossible to delete system tag
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested