refactor(apis): Remove AWS imports #2051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisterMX
force-pushed
the
refactor/remove-aws-imports
branch
from
37d9dc9
to
98e06ee
Compare
chlunde
approved these changes
Apr 25, 2024
Replace imported types with plane strings. Signed-off-by: Maximilian Blatt (external expert on behalf of DB Netz) <maximilian.blatt-extern@deutschebahn.com>
MisterMX
force-pushed
the
refactor/remove-aws-imports
branch
from
98e06ee
to
086a5b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This removes the import statements in
apisforgithub.com/aws/*and replaces all imported types with plain strings.It allows importing
apisin other Go modules without the necessity to import AWS SDK dependencies.It makes no breaking changes since the imported types where only just string type aliases.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
n.a.