Generated ECR Repository API & Controller #409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es necessary authorization methods that use v1 SDK. Signed-off-by: Muvaffak Onus <onus.muvaffak@gmail.com>
Signed-off-by: Muvaffak Onus <onus.muvaffak@gmail.com>
Signed-off-by: Muvaffak Onus <onus.muvaffak@gmail.com>
…splane command Signed-off-by: Muvaffak Onus <onus.muvaffak@gmail.com>
26 tasks
|
@muvaf taking a look at this |
AaronME
reviewed
May 28, 2021
Comment on lines
+56
to
+61
| cfg, err := awsclient.GetConfigV1(ctx, c.kube, mg, cr.Spec.ForProvider.Region) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| sess, err := session.NewSession(cfg) | ||
| return &external{client: svcapi.New(sess), kube: c.kube}, errors.Wrap(err, errCreateSession) |
There was a problem hiding this comment.
Based on https://aws.github.io/aws-sdk-go-v2/docs/migrating/ we can replace v1 session.NewSession with v2 NewFromConfig
Suggested change
| cfg, err := awsclient.GetConfigV1(ctx, c.kube, mg, cr.Spec.ForProvider.Region) | |
| if err != nil { | |
| return nil, err | |
| } | |
| sess, err := session.NewSession(cfg) | |
| return &external{client: svcapi.New(sess), kube: c.kube}, errors.Wrap(err, errCreateSession) | |
| cfg, err := awsclient.GetConfig(ctx, c.kube, mg, cr.Spec.ForProvider.Region) | |
| if err != nil { | |
| return nil, err | |
| } | |
| return &external{client: svcapi.NewFromConfig(cfg), kube: c.kube}, errors.Wrap(err, errCreateSession) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR serves as demonstration of how much code we are able to generate using ACK currently.
Generated by aws-controllers-k8s/community#449
Depends on #401
Fixes #448
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested creation and deletion manually.