Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lambda.function: code generated and custom parts are implemented #559

Merged
merged 2 commits into from
May 25, 2021
Merged

lambda.function: code generated and custom parts are implemented #559

merged 2 commits into from
May 25, 2021

Conversation

smcavallo
Copy link
Contributor

@smcavallo smcavallo commented Feb 23, 2021 •
edited
Loading

Description of your changes

Replaces PR #
#487
Fixes #
#173

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

  • Unit tests
  • Run in local crossplane using many different configurations
    • ensured resources were created/updated accordingly
    • ensured resources were updated accordingly
    • ensured resources did not continually update
      [contribution process]: https://git.io/fj2m9

@smcavallo smcavallo force-pushed the lambda branch 4 times, most recently from b13af13 to 611bc07 Compare March 1, 2021 18:31
@muvaf muvaf self-requested a review March 1, 2021 20:47
@muvaf muvaf self-assigned this Mar 1, 2021
@muvaf muvaf added this to In Progress in v1.1 Mar 1, 2021
@smcavallo smcavallo changed the title Lambda - WIP Lambda Function Support Mar 1, 2021
@smcavallo smcavallo marked this pull request as ready for review March 1, 2021 21:33
@smcavallo smcavallo changed the title Lambda Function Support lambda.function: code generated and custom parts are implemented Mar 2, 2021
muvaf
muvaf reviewed Mar 3, 2021
View reviewed changes
Copy link
Member

@muvaf muvaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @smcavallo ! This is a pretty good start!

apis/lambda/v1alpha1/custom_types.go Outdated Show resolved Hide resolved
apis/lambda/v1alpha1/custom_types.go Outdated Show resolved Hide resolved
apis/lambda/v1alpha1/custom_types.go Outdated Show resolved Hide resolved
apis/lambda/v1alpha1/referencers.go Outdated Show resolved Hide resolved
apis/lambda/v1alpha1/referencers.go Outdated Show resolved Hide resolved
pkg/controller/lambda/function/setup.go Show resolved Hide resolved
pkg/controller/lambda/function/setup.go Show resolved Hide resolved
pkg/controller/lambda/function/setup.go Outdated Show resolved Hide resolved
pkg/controller/lambda/function/setup.go Outdated Show resolved Hide resolved
pkg/controller/lambda/function/setup.go Outdated Show resolved Hide resolved
@muvaf muvaf mentioned this pull request Mar 3, 2021
Closed
2 tasks
@smcavallo smcavallo force-pushed the lambda branch 3 times, most recently from 7dcb72a to db08790 Compare March 5, 2021 00:36
@smcavallo
Copy link
Contributor Author

@muvaf - ready for re-review

@muvaf muvaf added this to In Progress in v1.2 Mar 9, 2021
@jbw976 jbw976 removed this from In Progress in v1.2 Mar 25, 2021
muvaf
muvaf reviewed Apr 7, 2021
View reviewed changes
Copy link
Member

@muvaf muvaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good in general. Though from what I can tell, we're able to use external name as is with this resource and not store ARN in its place. If that's possible, it would be the preferred approach instead of using provider-defined string as external name (ARN in this case).

pkg/controller/lambda/function/setup.go Outdated Show resolved Hide resolved
apis/lambda/v1alpha1/generator-config.yaml Outdated Show resolved Hide resolved
pkg/controller/lambda/function/setup.go Outdated Show resolved Hide resolved
pkg/controller/lambda/function/setup.go Show resolved Hide resolved
pkg/controller/lambda/function/setup.go Outdated Show resolved Hide resolved
apis/lambda/v1alpha1/referencers.go Outdated Show resolved Hide resolved
apis/lambda/v1alpha1/generator-config.yaml Show resolved Hide resolved
examples/lambda/function.yaml Outdated Show resolved Hide resolved
pkg/controller/lambda/function/setup.go Show resolved Hide resolved
pkg/controller/lambda/function/setup.go Outdated Show resolved Hide resolved
@smcavallo
lambda.function: code generated and custom parts are implemented
305d1b7 
Signed-off-by: smcavallo <smcavallo@hotmail.com>
@smcavallo
updated lambda function example
2c093a1 
Signed-off-by: smcavallo <smcavallo@hotmail.com>
muvaf
muvaf approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@muvaf muvaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @smcavallo !!

@muvaf muvaf merged commit a68cc43 into crossplane-contrib:master May 25, 2021
@jbw976 jbw976 mentioned this pull request Jun 3, 2021
Closed
@negz negz mentioned this pull request Jul 8, 2021
Closed
@negz negz removed this from In Progress in v1.1 May 26, 2022
@acelinkio acelinkio mentioned this pull request Apr 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan left review comments

@muvaf muvaf muvaf approved these changes

Assignees

@muvaf muvaf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@smcavallo @muvaf @hasheddan