iamrole, internetgateway: use awsclient err wrapper

[chlunde]

Using semgrep I found som additional places where awsclient.Wrap was not
used on an error from the AWS API.

docker run --rm -v "${PWD}:/src" returntocorp/semgrep --force-color -f ./err.yaml --lang=go ./pkg/controller/

err.yaml:

rules:
  - id: unclean-aws-err
    patterns:
	- pattern-either:
	    - patterns:
		- pattern: |
		    return managed.ExternalCreation{}, errors.Wrap(err, ...);

		- pattern-inside: |-
		    func ($T $TYPE) Create(...) {
			...
		    }
	      patterns:
		- pattern: |
		    return managed.ExternalUpdate{}, errors.Wrap(err, ...);

		- pattern-inside: |-
		    func ($T $TYPE) Update(...) {
			...
		    }
	      patterns:
		- pattern: |
		    return errors.Wrap(...);

		- pattern-inside: |-
		    func ($T $TYPE) Delete(...)  {
			...
		    }
	- pattern-not-inside: |
	    if err := $X.preCreate(...); err != nil {
	       ...
	    }

	- pattern-not-inside: |
	    if err := $X.preUpdate(...); err != nil {
	       ...
	    }

	- pattern-not-inside: |
	    if err := $X.preDelete(...); err != nil {
	       ...
	    }

	- pattern-not-inside: |
	    if err := e.kube.Status().Update(ctx, ...); err != nil {
		...
	    }

	- pattern-not-inside: |
	    if err := e.kube.Update(ctx, ...); err != nil {
		...
	    }

	- pattern-not: |
	    err = retry.OnError(..., func() error {
		...
	    })
	    if err != nil {
	       return ..., errors.Wrap(...)
	    }

	- pattern-not: |
	    return errors.Wrap(..., "pre-delete failed")

	- pattern-not: |
	    return ..., errors.Wrap(err, errPatchCreationFailed)

	- pattern-not: |
	    return ..., errors.Wrap(err, errCreatePatch)

    message: "errors.Wrap should be awsclient.Wrap with error from AWS API"
    languages: [go]
    severity: ERROR

Signed-off-by: Carl Henrik Lunde chlunde@ifi.uio.no

Description of your changes

Fixes #

I have:

• Read and followed Crossplane's contribution process.
• Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

[hasheddan]

@muvaf this looks like one we should get in 👍

[muvaf]

Thanks @chlunde !

[muvaf]

It was in draft but I wanted to merge it before the release since it looks like a fairly contained and known change.