database.rdsinstance: add DBSubnetParameterGroupName to late init #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unction so that isUpToDate works properly. Signed-off-by: Muvaffak Onus <me@muvaf.com>
namku
pushed a commit
to namku/provider-aws
that referenced
this pull request
Mar 9, 2021
database.rdsinstance: add DBSubnetParameterGroupName to late init
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Seems like it wasn't used in late-init because observation object returns an array. It's safe to assign the first value since there is more than value only during a change and that doesn't happen in creation where late-init is used.
Fixes crossplane/crossplane#2187
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Manually tested.