ec2.securitygroup: Handle nil fromPort/toPort (ipProtocol -1) #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ipProtocol is -1, fromPort/toPort will be nil. This causes a panic when sorting ingress/egress rules. We just need a stable sort so we can use an aws helper to get 0 for the value in that case. Fixes crossplane-contrib#616 Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
muvaf
approved these changes
Apr 8, 2021
|
Thanks! |
6 tasks
tektondeploy
pushed a commit
to gtn3010/provider-aws
that referenced
this pull request
Mar 12, 2024
Configure and add example for ResourceAssociation resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
When ipProtocol is -1, fromPort/toPort will be nil. This causes a panic
when sorting ingress/egress rules. We just need a stable sort so we can
use an aws helper to get 0 for the value in that case.
Also add a normal test for the sort functions (have more than one item so we will sort something).
Fixes #616
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested